Resolve Jira API requests between JSM/JS/Jira to correct permission map/resolver #62
Conversation
dxu2-atlassian
force-pushed
the
feat/EAS-2549
branch
6 times, most recently
from
fecbc4d to
7de9e27
Compare
| } | ||
| _ => { | ||
| warn!("First parameter to requestJira() is invalid"); | ||
| IntrinsicName::RequestJira // TODO: how should we handle this edge case? |
There was a problem hiding this comment.
If we want to produce the least amount of false positives, then we should conservatively assume it can use any of Jira APIs if we can't statically determine which one.
There was a problem hiding this comment.
Just to clarify, do you mean create another IntrinsicName enum like IntrinsicName::RequestJiraAny and then have that correspond to a combined resolver/regex map of JS + Jira + JSM here?
dxu2-atlassian
force-pushed
the
feat/EAS-2549
branch
from
7de9e27 to
8becec8
Compare
dxu2-atlassian
force-pushed
the
feat/EAS-2549
branch
from
7e81927 to
32f1b4f
Compare
| url if url.starts_with("/rest/servicedeskapi/") => { | ||
| Some(IntrinsicName::RequestJiraServiceManagement) | ||
| } | ||
| url if url.starts_with("/rest/agile/") => Some(IntrinsicName::RequestJiraSoftware), |
There was a problem hiding this comment.
There are other Jira Software URL patterns like /rest/devinfo and /rest/builds. See the API docs for others.
dxu2-atlassian
force-pushed
the
feat/EAS-2549
branch
from
32f1b4f to
3c16a92
Compare
| IntrinsicName::RequestJiraAny | ||
| }) | ||
| } else { | ||
| panic!("No url identifiable to classify requestJira() type"); |
There was a problem hiding this comment.
This should just fallback to RequestJiraAny instead of panicing.
| panic!("No url identifiable to classify requestJira() type"); | ||
| } | ||
| } | ||
| _ => { |
There was a problem hiding this comment.
You should also handle the case for when first_arg is a string literal: https://rustdoc.swc.rs/swc_ecma_ast/enum.Expr.html#variant.Lit.
dxu2-atlassian
force-pushed
the
feat/EAS-2549
branch
2 times, most recently
from
6d2bfc2 to
baa65b2
Compare
| @@ -1112,7 +1119,7 @@ impl<'cx> Dataflow<'cx> for PermissionDataflow { | |||
| interp.bitbucket_permission_resolver, | |||
| interp.bitbucket_regex_map, | |||
| ), | |||
| _ => unreachable!("Invalid intrinsic function type"), | |||
| _ => (&PermissionHashMap::new(), &HashMap::<String, Regex>::new()), | |||
There was a problem hiding this comment.
Could you add the rest of the cases to make this match exhaustive? So we don't forget to update this in the event that we add other services/intrinsics.
There was a problem hiding this comment.
Do we have a list of the rest of all the possible cases for this?
Is it just every possible case from here: https://developer.atlassian.com/platform/forge/apis-reference/fetch-api-product.requestbitbucket/
There was a problem hiding this comment.
No, I mean just filling out the match arm with the rest of the variants of IntrinsicName. There should be a rust_analyzer code action for doing this.
Also, you should install rust-analyzer if you haven't already.
|
LGTM once the match is exhaustive. |
dxu2-atlassian
force-pushed
the
feat/EAS-2549
branch
2 times, most recently
from
adb41bc to
d875900
Compare
…and handle existing bug
dxu2-atlassian
force-pushed
the
feat/EAS-2549
branch
from
d875900 to
4969d11
Compare
JSM/JS/Jira all seem to be bundled within requestJira inside Forge, this will separate those requests and route them to the proper permission map/resolver for classification.